fix: text input mask fixes #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasguyett
requested review from
gidjin,
haworku,
ahobson and
brandonlenz
as code owners
|
Thanks for the PR @nicholasguyett. I'll be taking a look at this and we will be incorporating in our next release. I'm currently looking through how to test this locally and appreciate your summary. |
rogeruiz
approved these changes
Sep 8, 2023
Comment on lines
+64
to
+73
| useEffect(() => { | ||
| // Make sure this component behaves correctly when used as a controlled component | ||
| setValue( | ||
| maskString( | ||
| ((externalValue ?? defaultValue) as string) ?? ``, | ||
| mask, | ||
| charset | ||
| ) | ||
| ) | ||
| }, [externalValue]) |
There was a problem hiding this comment.
Great work on this and using useEffect API hook.
Comment on lines
+81
to
+82
| // Ensure the new value is available to upstream onChange listeners | ||
| e.target.value = newValue |
There was a problem hiding this comment.
Good catch here on ensuring other onChange listeners get the value here too.
|
@all-contributors please add @nicholasguyett for bug, code |
|
We had trouble processing your request. Please try again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the incorrect pass-through of the
inputRefpropAdds support for
defaultValueAdds support for using
TextInputMaskas a controlled componentFixes support for externally set
onChangehooksNote: The
maskStringfunction contains the unmodified original masking implementation, just moved into a separate function so it can be called in bothonChangeand when setting the initial state.Related Issues or PRs
How To Test
Manually tested this change in an external (currently private) application that uses both
defaultValueandonChange.Screenshots (optional)