docs: Point users to react-fontawesome for icons #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim
requested review from
ahobson,
gidjin,
haworku,
sarboc,
suzubara and
tinyels
as code owners
suzubara
reviewed
Jul 29, 2020
example/src/pages/Icons.tsx
Outdated
| <h1>Icons</h1> | ||
|
|
||
| <p className="usa-intro"> | ||
| We recommend using icons from <a href="https://www.google.com/search?client=safari&rls=en&q=react-fontawesome&ie=UTF-8&oe=UTF-8">react-fontawesome</a> for projects that need icons. |
There was a problem hiding this comment.
did you mean to link to the google search results instead of react-fontawesome on github?
|
To respond to your @jim comment in the PR description - I like how you added it to the example page. It doesn't hurt to remind folks a few ways this exists. thanks! |
added 2 commits
July 30, 2020 10:47
haworku
previously approved these changes
Jul 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds documentation to the README that recommends the use of
react-fontawesomefor projects that need icons.I'm not sure if/what should be added to the example app. I put a page in there to make sure that the icons worked, but I can take that out if it doesn't make sense to keep since it is testing an external dependency.
Related Issues or PRs
closes #84
How To Test
Screenshots
Here is the new page in the example app:
Checklist
yarn auditoutput if dependencies changedindex.ts