-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deprecate the Modal component #956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonlenz
requested review from
ahobson,
gidjin,
haworku,
sarboc,
SirenaBorracha,
suzubara and
tinyels
as code owners
February 24, 2021 18:43
haworku
approved these changes
Mar 5, 2021
suzubara
added
the
type: breaking
This introduces breaking changes and will require a major version increase
label
Apr 12, 2021
brandonlenz
added a commit
that referenced
this pull request
May 12, 2021
BREAKING CHANGE: Modal has been removed from React USWDS. The USWDS Modal from 2.11.x will be implemented once React USDWS reaches parity with USWDS 2.11.x
brandonlenz
added a commit
that referenced
this pull request
May 12, 2021
BREAKING CHANGE: The Modal component has been removed. The USWDS Modal will be added when reaching parity with USWDS 2.11.x
Merged
Where will Modal live in the future? I just started using react-uswds and I am using Modal. |
Oh, I see! I'm using react-uswds 2.6.0, so I guess that I am already using the new Modal component. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Modal Component is not a part of
uswds
and is therefore being removed from the library.As this is a breaking change, it is targeting the V2 release of
react-uswds
Related Issues or PRs
closes #787
How To Test
Modal
are removed.