Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate the Modal component #956

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Conversation

brandonlenz
Copy link
Contributor

@brandonlenz brandonlenz commented Feb 24, 2021

⚠️ Per #787 the modal component is to be relocated to a Truss-specific repo: The modal component will always be available in the git history, but after merging this PR, that will be the only place to find it.

Summary

The Modal Component is not a part of uswds and is therefore being removed from the library.

As this is a breaking change, it is targeting the V2 release of react-uswds

Related Issues or PRs

closes #787

How To Test

  1. Checkout this branch
git fetch
git checkout bl-deprecate-modal-breaking-787
  1. Verify all references to Modal are removed.
  2. Example App runs (Modal and redux have been removed from the example app)

@trussworks-infra-zz
Copy link

trussworks-infra-zz commented Feb 24, 2021

Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 5e87f28

@brandonlenz brandonlenz added this to the v2 milestone Feb 25, 2021
@brandonlenz brandonlenz merged commit 4262247 into V2 Mar 15, 2021
@brandonlenz brandonlenz deleted the bl-deprecate-modal-breaking-787 branch March 15, 2021 22:50
@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook March 15, 2021 22:51 Inactive
@suzubara suzubara added the type: breaking This introduces breaking changes and will require a major version increase label Apr 12, 2021
@suzubara suzubara removed this from the v2 milestone Apr 12, 2021
brandonlenz added a commit that referenced this pull request May 12, 2021
BREAKING CHANGE: Modal has been removed from React USWDS. The USWDS Modal from 2.11.x will be implemented once React USDWS reaches parity with USWDS 2.11.x
brandonlenz added a commit that referenced this pull request May 12, 2021
BREAKING CHANGE: The Modal component has been removed. The USWDS Modal will be added when reaching parity with USWDS 2.11.x
@lpsinger
Copy link
Contributor

lpsinger commented Jan 2, 2022

Where will Modal live in the future? I just started using react-uswds and I am using Modal.

@kalvinwang
Copy link

@lpsinger USWDS actually added a modal back to their library a year ago, so ReactUSWDS now contains a new version of the modal, as described here: #1622

@lpsinger
Copy link
Contributor

Oh, I see! I'm using react-uswds 2.6.0, so I guess that I am already using the new Modal component. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking This introduces breaking changes and will require a major version increase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants