fix: set CombBox focusMode to BLUR when focus is outside of the component #989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #901, we ensured that the combo box's
focusMode
was set toBLUR
when a user clicked outside of the component. This is not sufficient for keyboard shortcuts, such as tabbing. When a user tabs through input fields, the focus on the combo box isn't reset.*I also added an additional story that puts a text input next to the combo box to make it easier for folks to test. Since we've had some issues surrounding focus, I think it'd be good to have for testing.
Related Issues or PRs
#901
#902
How To Test
The form must have at least 2 elements to interact with. I used the combo box and a text input.
tab
to focus the next fieldPrior to the fix, the user's focus would be shifted back to the combo box.
After the fix, the user is able to continue typing in the text input