-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not support BTC Taproot address or SegWit address? #3821
Comments
Hi @Sunshineyg00, we're already working on this, thank you for noticing |
Thank you for your reply and your tremendous effort! |
whats the status on this? let taprootKey = wallet.getKey(coin: .bitcoin, derivationPath: "m/86'/0'/0'/0/0") does not generate a valid taproot address |
Hi @nftsupply, @Sunshineyg00 we finished working on full BTC Rust migration, and P2TR address generation is coming soon. I'll give an update once it's ready for the production use |
Why migration Rust is necessary? the Main SKD is in Rush? |
An API to generate Taproot address has been added at #4074 |
Describe the bug
When using TWBitcoinAddressIsValidString to verify a correct BTC Taproot address or a SegWit address, the return result is NO, which should be right.
To Reproduce
Steps to reproduce the behavior:
NSLog(@"--== btc: %d", TWBitcoinAddressIsValidString(TWStringCreateWithUTF8Bytes(@"bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq".UTF8String)));
NSLog(@"--== btc: %d", TWBitcoinAddressIsValidString(TWStringCreateWithUTF8Bytes(@"bc1p5d7rjq7g6rdk2yhzks9smlaqtedr4dekq08ge8ztwac72sfr9rusxg3297".UTF8String)));
Expected behavior
The results are both "YES" as these are valid addresses.
The text was updated successfully, but these errors were encountered: