Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

不支持 dsa 算法私钥 #33

Closed
ruanimal opened this issue Jul 10, 2023 · 7 comments
Closed

不支持 dsa 算法私钥 #33

ruanimal opened this issue Jul 10, 2023 · 7 comments

Comments

@ruanimal
Copy link

如题

parse private key [/Users/ruan/.ssh/id_dsa] failed: ssh: unhandled key type

@lonnywong
Copy link
Member

DSA 私钥是怎么生成的,多少位的?

@ruanimal
Copy link
Author

ruanimal commented Jul 10, 2023

macOS 12 带的 ssh-keygen 应该是没有问题的

ssh-keygen -t dsa
Generating public/private dsa key pair.
Enter file in which to save the key (/Users/ruan/.ssh/id_dsa):
Enter passphrase (empty for no passphrase):
Enter same passphrase again:
Your identification has been saved in /Users/ruan/.ssh/id_dsa
Your public key has been saved in /Users/ruan/.ssh/id_dsa.pub
The key fingerprint is:
SHA256:h3IiL+STmUUpwOrWpxHX+/t5fNb8QksR+C/XaIhLFJE ruan@ruandeMacBook-Pro
The key's randomart image is:
+---[DSA 1024]----+
| ..       .o .   |
|  ..   .  E . .  |
| .  . +    . . . |
|.  . + . ..   o  |
|. . = + S... . +.|
| o = O = .o . * +|
|.   @ . .. ..+ =.|
|   . o   .. .oooo|
|         .oo. o.o|
+----[SHA256]-----+

@lonnywong
Copy link
Member

我试了一下,发现只支持 1024 位的:

$ ssh-keygen -t dsa -b 2048
Invalid DSA key length: must be 1024 bits

1024 位的私钥已经不安全了,据说 openssh 加上 dsa 是个错误:golang/go#23751 (comment) ,看来下个版本要把对 dsa 的支持删了。

@ruanimal
Copy link
Author

dsa 已经被 openssh 默认禁用了,dsa 支持确实可以删除了。

另外,建议 tssh 解析文件失败提示一些warning信息就ok了,别直接退出。

@lonnywong
Copy link
Member

OK,我周末优化一下这里的逻辑。

@lonnywong
Copy link
Member

v0.1.7 已优化。

@ruanimal
Copy link
Author

最新版本功能已经正常

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants