Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors getting logged without call stack or context #137

Closed
JoshuaKGoldberg opened this issue Dec 19, 2021 · 0 comments · Fixed by #176
Closed

Errors getting logged without call stack or context #137

JoshuaKGoldberg opened this issue Dec 19, 2021 · 0 comments · Fixed by #176

Comments

@JoshuaKGoldberg
Copy link

JoshuaKGoldberg commented Dec 19, 2021

In reproducing #136, what you actually see on the terminal is:

$ tsd
Cannot read properties of undefined (reading 'flags')

No call stack. It's quite confusing.

The culprit is logging only the message here: https://github.com/SamVerschueren/tsd/blob/354f77d97315045770c1a94a4f16ef507c865dbd/source/cli.ts#L30

Could we have, say, a message like Error running tsd: ${error.stack || error.message} please? I'd be happy to send a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant