Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy up union #1095

Closed
petrelharp opened this issue Dec 23, 2020 · 0 comments · Fixed by #1108
Closed

tidy up union #1095

petrelharp opened this issue Dec 23, 2020 · 0 comments · Fixed by #1108
Assignees
@petrelharp

Comments

@petrelharp
Copy link
Contributor

A few things:

  • there's a note that says we can remove the restriction that the non-shared bits of other not be above the shared bit. I think we can do this now, since we're sorting on mutation time.
  • I don't think that we're checking whether the same value appears more than once in node_mapping, and I suspect this could make bad things happen - but, maybe it's ok?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrelharp petrelharp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updates to union, subset, and sort petrelharp/tskit
1 participant
@petrelharp