Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative path is wrong when referencing file outside of project folder #423

Closed
damirdavletov opened this issue May 20, 2019 · 0 comments · Fixed by #424
Closed

Relative path is wrong when referencing file outside of project folder #423

damirdavletov opened this issue May 20, 2019 · 0 comments · Fixed by #424

Comments

@damirdavletov
Copy link
Contributor

damirdavletov commented May 20, 2019

What 🌱

When referencing file higher in folder hierarchy than sourceRoot relative path is calculated incorrectly. e.g. if you have the structure like this:

/root/Project1/Project1.xcodeproj
/root/Project2/Project2.xcodeproj

And then add Project2 reference to Project1 then the path is calculated incorrectly as /root/Project2/Project2.xcodeproj while it should be ../Project2/Project2.xcodeproj

Proposal 🎉

Attaching the proposed fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant