Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Thread Performance Checker scheme diagnostics option #693

Closed
kwridan opened this issue Jun 28, 2022 · 4 comments Β· Fixed by #694
Closed

Add support for Thread Performance Checker scheme diagnostics option #693

kwridan opened this issue Jun 28, 2022 · 4 comments Β· Fixed by #694

Comments

@kwridan
Copy link
Collaborator

kwridan commented Jun 28, 2022

Context πŸ•΅οΈβ€β™€οΈ

In Xcode 14 there's a new "Thread Performance" runtime checker that is enabled by default. This can be configured within the scheme's Run action (LaunchAction).

Screenshot 2022-06-28 at 07 11 02

What 🌱

The new option appears in the LaunchAction only if disabled and omitted if enabled (similar to main thread checker).

    <LaunchAction
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
       disableMainThreadChecker = "YES"
+      disablePerformanceAntipatternChecker = "YES"
       launchStyle = "0"
       useCustomWorkingDirectory = "NO"
       ignoresPersistentStateOnLaunch = "NO"
       debugDocumentVersioning = "YES"
       debugServiceExtension = "internal"
       allowLocationSimulation = "YES">
       <BuildableProductRunnable
          runnableDebuggingMode = "0">
          <BuildableReference
             BuildableIdentifier = "primary"
             BlueprintIdentifier = "FB2F4AA5286220B400DF0A62"
             BuildableName = "TemplateApp.app"
             BlueprintName = "TemplateApp"
             ReferencedContainer = "container:TemplateApp.xcodeproj">
          </BuildableReference>
       </BuildableProductRunnable>
    </LaunchAction>

Proposal πŸŽ‰

  • Introduce a disablePerformanceAntipatternChecker property on XCScheme.LaunchAction
  • It should be placed immediately after disableMainThreadChecker in the generated scheme

Notes

  • This option currently appears under the Run action (LaunchAction) only and not under the Test action.
@leszko11
Copy link
Collaborator

Hi @kwridan!

I can tackle this one :)

@fortmarek
Copy link
Member

That's great to hear @leszko11! Let us know if you need any help πŸ™‚

@kwridan
Copy link
Collaborator Author

kwridan commented Jun 30, 2022

Thanks @leszko11 !

Looks like @Bogdan-Belogurov has already submitted #694

@leszko11
Copy link
Collaborator

Oh, @Bogdan-Belogurov is fast πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants