Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of wrong default no-accept-focus frame parameter #136

Open
gerd-moellmann opened this issue Mar 4, 2024 · 2 comments
Open

Use of wrong default no-accept-focus frame parameter #136

gerd-moellmann opened this issue Mar 4, 2024 · 2 comments

Comments

@gerd-moellmann
Copy link

The default for key parameter accept-focus of posframe--create-posframe is nil. That means any caller of that function which doesn't explicitly specify a keyword argument :accept-focus t will use a no-accept-focus t frame parameter.

This leads to warnings under macOS, for which I submitted bug 69525 to Emacs. I propose the following change:

modified   posframe.el
@@ -579,7 +579,7 @@ You can use `posframe-delete-all' to delete all posframes."
                                      override-parameters
                                      respect-header-line
                                      respect-mode-line
-                                     accept-focus)
+                                     (accept-focus t))
   "Create and return a posframe child frame.
 This posframe's buffer is BUFFER-OR-NAME.

@tumashu
Copy link
Owner

tumashu commented Mar 5, 2024

it has other bug, need no-accept-focus t by default.

@gerd-moellmann
Copy link
Author

gerd-moellmann commented Mar 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants