refactor: useless NOTE comment & unused vars #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knokmki612
commented
Sep 1, 2021
| @@ -3,7 +3,6 @@ const theme = require("./theme"); | |||
| const buttonStyle = require("./lib/buttonStyle"); | |||
|
|
|||
| module.exports = plugin.withOptions( | |||
| // NOTE: couldn't merge plugin-side theme when wrote the plugin without withOptions | |||
There was a problem hiding this comment.
https://tailwindcss.com/docs/plugins#exposing-advanced-configuration-options
プラグイン内で独自に定義しているカラーコードなどを参照するには、 plugin.withOptions で記述する必要があるのは仕様なので、この書き方で問題なく、NOTEコメントに残す必要はないと理解したのでコメントを取り除きました
|
ありがとうございます、hideki-trialで取り込んでおきました。 @knokmki612 |
|
このプルリクエストのマージ先はもともとhideki-trialになっていました。 |
|
まだ(リモートの)hideki-trialにマージされていないようだったので、このプルリクエストは一度closeしましたがreopenしました |
knokmki612
force-pushed
the
refactor-tailwindcss-plugin
branch
from
8f21f25 to
dfea177
Compare
|
失礼、取り込んでおきました |
|
@Hidetaro7 コンフリクト解消時の操作を誤ったのでtypography.jsが復活してしまいました。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.