Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts filtered with "Warn" should show filter name, not matched phrase #3587

Closed
1 task done
digitalcircuit opened this issue Apr 28, 2023 · 0 comments · Fixed by #3589
Closed
1 task done

Posts filtered with "Warn" should show filter name, not matched phrase #3587

digitalcircuit opened this issue Apr 28, 2023 · 0 comments · Fixed by #3589
Assignees

Comments

@digitalcircuit
Copy link

digitalcircuit commented Apr 28, 2023

In brief

  • Tusky should use the filter name for Warn v2 filters, not the matched phrase
    • Shows whatever context desired for the filter (e.g. "Twitter retweets")
    • Can avoid showing potentially overwhelming phrases (e.g. racist language, politics, relationships)
    • Matches upstream Mastodon behavior

Testing

Steps

  1. Connect Tusky v22.0-beta.1 to an instance supporting the v2 of the Mastodon filtering API
  2. Add a filter matching some text and give the filter a different name (e.g. My filter matching the word example phrase)
  3. Save and apply
  4. Browse the timeline until you find a toot that gets filtered
  5. Observe how it is shown

Expected

Tusky hides the toot behind a warning that says Filtered: My filter.

Screenshot of Mastodon showing a warning filter in action, revealing the filter name

Filtered: Twitter retweets. Show anyway

Actual

Tusky does hide the toot, but reveals the exact phrase matched instead of using the filter name, e.g. Filtered: example phrase.

Screenshot of Tusky showing a warning filter in action, revealing the exact matched phrase

Filtered: RT @
Show anyway


  • Tusky Version: v22.0-beta.1

  • Android Version: 13 (TQ2A.230405.003.E1)

  • Android Device: Pixel 4 XL

  • Mastodon instance (if applicable): N/A

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@nikclayton nikclayton self-assigned this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants