You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
Dont try to register '.' as an installable, or expand . to be a complete path, and even better would be to determine the git repo and hash to make it reproducible.
Desktop (please complete the following information):
A more vague pip example found via history import:
[ ] requirements.txt (Python Pip)
There, the name requirements.txt could actually be a valid PyPI name, so simply doing heuristics on package name wouldnt suffice, however it would be a great first implementation.
I've added a heuristic that ignores packages that start with a special character. The requirements.txt for Python is a bit of a different case, I think I'll need to have a blacklist for each package manager for that.
Describe the bug
Installing a path of
.
shouldnt be registered as '.'.To Reproduce
Expected behavior
Dont try to register '.' as an installable, or expand
.
to be a complete path, and even better would be to determine the git repo and hash to make it reproducible.Desktop (please complete the following information):
Machine information
Software version
emplace 1.3.1-alpha.0
Operating system
Darwin 20.3.0
Environment variables
SHELL=/usr/local/bin/zsh EMPLACE_CONFIG='/Users/john.vandenberg/Library/Application Support/emplace.toml'
Git version
Compile time information
The text was updated successfully, but these errors were encountered: