From 8b087c8b31c884bc100b1cfe1cb946731e191deb Mon Sep 17 00:00:00 2001 From: balopat Date: Fri, 8 Mar 2019 12:23:24 -0800 Subject: [PATCH 1/3] added some extra logging for test failures for easier feedback --- test.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test.sh b/test.sh index e0ebb1c58de..1ed7082ec9a 100755 --- a/test.sh +++ b/test.sh @@ -19,11 +19,16 @@ set -e RED='\033[0;31m' GREEN='\033[0;32m' RESET='\033[0m' +LOGFILE=`mktemp` echo "Running go tests..." -go test -cover -short -v -timeout 60s ./... | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' +go test -cover -short -v -timeout 60s ./... 2>&1 | tee ${LOGFILE} | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' GO_TEST_EXIT_CODE=${PIPESTATUS[0]} if [[ $GO_TEST_EXIT_CODE -ne 0 ]]; then + echo "*****" + echo "***** 'go test' failed (log file: ${LOGFILE}) *****" + echo "*****" + grep "FAIL" ${LOGFILE} -C 2 | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' exit $GO_TEST_EXIT_CODE fi From 1124edadf745d20896e2fccfe7776b30a4a54a07 Mon Sep 17 00:00:00 2001 From: balopat Date: Fri, 8 Mar 2019 16:44:48 -0800 Subject: [PATCH 2/3] Revert "added some extra logging for test failures for easier feedback" This reverts commit 8b087c8b31c884bc100b1cfe1cb946731e191deb. --- test.sh | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test.sh b/test.sh index 1ed7082ec9a..e0ebb1c58de 100755 --- a/test.sh +++ b/test.sh @@ -19,16 +19,11 @@ set -e RED='\033[0;31m' GREEN='\033[0;32m' RESET='\033[0m' -LOGFILE=`mktemp` echo "Running go tests..." -go test -cover -short -v -timeout 60s ./... 2>&1 | tee ${LOGFILE} | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' +go test -cover -short -v -timeout 60s ./... | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' GO_TEST_EXIT_CODE=${PIPESTATUS[0]} if [[ $GO_TEST_EXIT_CODE -ne 0 ]]; then - echo "*****" - echo "***** 'go test' failed (log file: ${LOGFILE}) *****" - echo "*****" - grep "FAIL" ${LOGFILE} -C 2 | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' exit $GO_TEST_EXIT_CODE fi From 74116c179b3fcd38eaa62ebf1bba686b94d82d16 Mon Sep 17 00:00:00 2001 From: balopat Date: Fri, 8 Mar 2019 16:45:06 -0800 Subject: [PATCH 3/3] dropping -v --- test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test.sh b/test.sh index e0ebb1c58de..8b8a3788074 100755 --- a/test.sh +++ b/test.sh @@ -21,7 +21,7 @@ GREEN='\033[0;32m' RESET='\033[0m' echo "Running go tests..." -go test -cover -short -v -timeout 60s ./... | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' +go test -cover -short -timeout 60s ./... | sed ''/PASS/s//$(printf "${GREEN}PASS${RESET}")/'' | sed ''/FAIL/s//$(printf "${RED}FAIL${RESET}")/'' GO_TEST_EXIT_CODE=${PIPESTATUS[0]} if [[ $GO_TEST_EXIT_CODE -ne 0 ]]; then exit $GO_TEST_EXIT_CODE