Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal with remote url doesn't display correctly #11624

Closed
Eonasdan opened this issue Nov 26, 2013 · 1 comment · May be fixed by TheLOGOGuy/bootstrap#12 or Tripooly/bootstrap#11
Closed

modal with remote url doesn't display correctly #11624

Eonasdan opened this issue Nov 26, 2013 · 1 comment · May be fixed by TheLOGOGuy/bootstrap#12 or Tripooly/bootstrap#11

Comments

@Eonasdan
Copy link

Since the change with bs3 using a remote url with a modal doesn't display correctly.

<a data-toggle="modal" href="URL" data-target="#MODAL" tabindex=-1>Click Me</a>
<div class="modal fade" id="MODAL" tabindex="-1" role="dialog" aria-hidden="true">
    content ends up here!
</div>
<div class="modal fade" id="MODAL" tabindex="-1" role="dialog" aria-hidden="true">
    <div class="modal-dialog">
        <div class="modal-content">
            <div class="modal-body">
                    content should go here
            </div>
            <div class="modal-footer">
                <button class="btn" data-dismiss="modal" aria-hidden="true">Close</button>
            </div>
        </div>
    </div>
</div>

adding

<div class="modal-dialog">
    <div class="modal-content">
        <div class="modal-body">
            ...

to the remote url fixes the issue

@cvrebert
Copy link
Collaborator

This is a deliberate change in semantics that is already mentioned in the migration docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants