Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "well" with contextual background does not change bg color... #13331

Closed
jbruni opened this issue Apr 13, 2014 · 7 comments
Closed

Using "well" with contextual background does not change bg color... #13331

jbruni opened this issue Apr 13, 2014 · 7 comments

Comments

@jbruni
Copy link

jbruni commented Apr 13, 2014

I've coded:

<div class="well bg-success">some text</div>

But I didn't get the green background color.

Shouldn't the well component accept the contextual background class background-color?

@jbruni
Copy link
Author

jbruni commented Apr 13, 2014

A fantastic JSBin showing the issue: http://jsbin.com/tiqaqiwo/1/

@cvrebert
Copy link
Collaborator

No, we use component-specific contextual classes (e.g. .alert-success) rather than generic ones (e.g. .success), and the .bg-* classes are not defined as having any special interaction/effect on Bootstrap's built-in components (I believe the docs already warn about this).
Adding contextual well variants (e.g. well-success) would be a reasonable request though.

@cvrebert
Copy link
Collaborator

@mdo So, you'd be in favor of adding .well-danger etc.?

@mdo
Copy link
Member

mdo commented Apr 25, 2014

@cvrebert I'm against the contextual wells.

Edit: Too close to the generic background classes and the like. We've gotten rather redundant and overly verbose on a lot of things.

@cvrebert
Copy link
Collaborator

Closing then, since the feature request was denied and the documentation deficiency was addressed by #13332.

@bradlis7
Copy link

+1. Maybe you could style it as .well.bg-success, as well as changing .alert.bg-success instead of having a contextual class for each item type. It might be confusing because it would change the border color, and it's called bg, but I don't think people would complain.

Either that, or provide .alert .alert-default, and mark well as depreciated.

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 3, 2015

We are reworking our approach to alerts/wells/panels in Bootstrap v4.

@twbs twbs locked and limited conversation to collaborators Jan 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants