-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add destroy method to all plugins #13655
Comments
yeah… might be worth adding teardown functions to all plugins |
i also updated that question with a much better answer… that person didn't really want a destroy method |
Punting to the v4 checklist. |
I'm using the affix plugin in a single page application. When I remove the affixed content from the dom I call $(window).off('.affix') to avoid a memory leak. A documented "destroy" method would help users of the affix plugin to avoid memory leaks. In the docs it might be helpful to call out the memory leak pitfall- "if you're using the affix plugin in a single page application be sure to destroy it when you remove the affixed content" or something. Any chance this issue can be re-opened? My stackoverflow post: http://stackoverflow.com/questions/21713468/bootstrap-affix-plugin-memory-leak/ |
1+ |
[WAS: add destroy method to affix]
See e.g. http://stackoverflow.com/questions/23797241/resetting-changing-the-offset-of-bootstrap-affix
The text was updated successfully, but these errors were encountered: