Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover is not positioned correctly when viewport property is used #15627

Closed
amiklosi opened this issue Jan 21, 2015 · 2 comments
Closed

Popover is not positioned correctly when viewport property is used #15627

amiklosi opened this issue Jan 21, 2015 · 2 comments

Comments

@amiklosi
Copy link

You can see the issue in this fiddle: http://jsfiddle.net/699rsu57/

The fix is actually quite easy for this:
In tooltip.js getViewportAdjustedDelta function the line

} else if (rightEdgeOffset > viewportDimensions.width) { // right overflow

should read

} else if (rightEdgeOffset > viewportDimensions.right) { // right overflow

@klakshman318
Copy link

Try like this 👍

screen

@cvrebert cvrebert added the js label Jan 21, 2015
@cvrebert cvrebert added this to the v3.3.5 milestone Apr 8, 2015
@fat
Copy link
Member

fat commented May 5, 2015

in v4 we're going to rewrite the position engine/use a 3rd party one.

meanwhile - i'm happy to review a pr if you or someone else wants to make this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants