Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARIA attributes to collapsed navbar (similar to dropdown) #16099

Closed
jmuheim opened this issue Mar 18, 2015 · 1 comment · Fixed by #16140
Closed

Add ARIA attributes to collapsed navbar (similar to dropdown) #16099

jmuheim opened this issue Mar 18, 2015 · 1 comment · Fixed by #16140
Assignees
@patrickhlauke
Labels
accessibility docs

Comments

@jmuheim
Copy link

jmuheim commented Mar 18, 2015

While the dropdown has nice accessibility support using ARIA attributes (e.g. aria-expanded), the navbar's "Toggle navigation" button (only displayed on small screen resolutions) doesn't have any ARIA attributes.

This is necessary for people on mobile devices who are using screenreaders (e.g. VoiceOver on iOS).
@patrickhlauke
Copy link
Member

Funnily enough, I was looking at that exact thing this morning (as part of #16096). Leave it with me :)

@patrickhlauke patrickhlauke self-assigned this Mar 18, 2015
@patrickhlauke patrickhlauke mentioned this issue Mar 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickhlauke patrickhlauke

Labels
accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aria-expanded to navbar toggles
2 participants
@patrickhlauke @jmuheim