-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Border-color of form feedback success/warning/error states cannot easily be changed #17718
Comments
Duplicate of #12731. |
To be clear, I'm not suggesting changing it to the |
CC: @mdo |
Can this be reopened or get a response? |
"Nothing will change here until v4" -- #12731 (comment) |
But my change can be done fully backwards compatible. |
I think what is failing to be explained by the team @JelteF isn't that this is a feature which isn't implementable in a manner that is backwards compatible but rather has failed to mention that active development of V3 has ended and V3 is in support-only mode until an unknown date (tbd by core team). Currently, only severe bug fixes are being addressed. At this point all feature requests, implementations, etc are to be done against V4. Patches for your own repositories or forks of V3 are also always an option though neither would have the core team's support and would be your own / with the assistance of the community (eg stackoverflow) |
Ah alright, thanks for the explanation. |
For some reason the border-color argument uses the same color as the text. Which results in very dark borders, especially when focussed. When you want to change this it requires calling of the mixin again, instead of just changing a color variable. See these two snippets for the code in question:
And see this for an example of dark borders: http://getbootstrap.com/css/#forms-control-validation
The main suggestion is the usage of another variable for this so it can at least be changed without changing the text. The second is changing the default to make it lighter.
There already is a variable called
$state-warning-border
, but that is too light to use as border color for inputs. If that would be made darker it could be used for all.I could try to add this myself, but I would first like to know what idea you think is best.
The text was updated successfully, but these errors were encountered: