Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border-color of form feedback success/warning/error states cannot easily be changed #17718

Closed
JelteF opened this issue Sep 27, 2015 · 8 comments
Labels

Comments

@JelteF
Copy link

JelteF commented Sep 27, 2015

For some reason the border-color argument uses the same color as the text. Which results in very dark borders, especially when focussed. When you want to change this it requires calling of the mixin again, instead of just changing a color variable. See these two snippets for the code in question:

The main suggestion is the usage of another variable for this so it can at least be changed without changing the text. The second is changing the default to make it lighter.

There already is a variable called $state-warning-border, but that is too light to use as border color for inputs. If that would be made darker it could be used for all.

I could try to add this myself, but I would first like to know what idea you think is best.

@cvrebert cvrebert changed the title Border-color of success/warning/error cannot easily be changed Border-color of form feedback success/warning/error states cannot easily be changed Sep 27, 2015
@cvrebert
Copy link
Collaborator

Duplicate of #12731.

@JelteF
Copy link
Author

JelteF commented Sep 27, 2015

To be clear, I'm not suggesting changing it to the -border variant. My main change would be just a separate variable, which can default to the value of the -text variant of the variables. Just so it is not necessary to call the mixin for all cases, but it is possible to change a default variable.

@cvrebert
Copy link
Collaborator

CC: @mdo

@JelteF
Copy link
Author

JelteF commented Nov 8, 2015

Can this be reopened or get a response?

@cvrebert
Copy link
Collaborator

cvrebert commented Nov 8, 2015

"Nothing will change here until v4" -- #12731 (comment)

@JelteF
Copy link
Author

JelteF commented Nov 8, 2015

But my change can be done fully backwards compatible.

@kkirsche
Copy link
Contributor

kkirsche commented Nov 8, 2015

I think what is failing to be explained by the team @JelteF isn't that this is a feature which isn't implementable in a manner that is backwards compatible but rather has failed to mention that active development of V3 has ended and V3 is in support-only mode until an unknown date (tbd by core team). Currently, only severe bug fixes are being addressed.

At this point all feature requests, implementations, etc are to be done against V4. Patches for your own repositories or forks of V3 are also always an option though neither would have the core team's support and would be your own / with the assistance of the community (eg stackoverflow)

@JelteF
Copy link
Author

JelteF commented Nov 9, 2015

Ah alright, thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants