Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of base text direction for Bootstrap v4 JS widgets #20378

Closed
ashensis opened this issue Jul 27, 2016 · 3 comments
Closed

Support of base text direction for Bootstrap v4 JS widgets #20378

ashensis opened this issue Jul 27, 2016 · 3 comments

Comments

@ashensis
Copy link

ashensis commented Jul 27, 2016

The important requirement to any program product from the Arabic/Hebrew customer's perspective is support for base text direction. For detailed explanation of what base text direction term means please see, for instance, pages 5-9 of the following reference document.

https://docs.google.com/document/d/1dDrSwimrQbpbXybhMYDEiJXLeeqvelnY4cc8HeCP1Nk/edit?usp=sharing

Every platform (like MS Office or Open Office) or web based (like CKEditor, IBM Docs) text editor as well as large variety of program products and platforms (like dojo) allows the possibility to specify the base text direction that impacts the display of Arabic/Hebrew text.
The current proposal is to introduce the base text direction into Bootstrap JS widgets. Possible candidates for support are Popover and Tooltip (these widgets create their HTML markup dynamically).

How to specify 'base text direction' for bootstrap widgets
Bootstrap widgets would provide BTD basing on 'textdir' option been passed to widget constructor.
Alternatively BTD may be specified decoratively as 'data-textdir' attribute of corresponding html element.

Allowed values are: "ltr" (left-to-right), "rtl" (right-to-left) and
"contextual" (meaning that either 'ltr' or 'rtl' value is used depending on
the first strong(Arabic/Hebrew or English) character of string been displayed.

@mdo
Copy link
Member

mdo commented Jul 28, 2016

If we did this, it'd be part of a holistic RTL approach, something we don't have the ability to undertake at this point. Passing on this until then.

@mdo mdo closed this as completed Jul 28, 2016
@tomerm
Copy link

tomerm commented Jul 28, 2016

@mdo and @cvrebert based on "For now, please wait until we ship a stable v4.0.0 release. At that point, we'd gladly welcome a pull request that implements a primarily-conversion-tool-based approach to RTL." from #19555 , it looks like PRs associated with basic Bidi / RTL support are welcomed after shipment of first stable v4.0.0. Proper layout and display of bidirectional text (Arabic / Hebrew / Farsi etc.) discussed in this ticket is inseparable from GUI mirroring described in #19555 . We would appreciate if you can allow us to submit a PR (once stable v4.0.0 releases) illustrating the functionality described in this ticket.

Many thanks in advance.

PS. @ashensis who created this ticket is part of my development team called Bidi Development Lab. We join efforts with Arabic Competence and Globalization Center (opened #19555 ) in addressing Bidi (Arabic / Hebrew ) requirements in variety of technologies.

@cvrebert
Copy link
Collaborator

it looks like PRs associated with basic Bidi / RTL support are welcomed after shipment of first stable v4.0.0.

That is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants