Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.invalid-feedback still appears on valid elements #23372

Closed
charles-toller opened this issue Aug 12, 2017 · 3 comments
Closed

.invalid-feedback still appears on valid elements #23372

charles-toller opened this issue Aug 12, 2017 · 3 comments

Comments

@charles-toller
Copy link

charles-toller commented Aug 12, 2017

I'm running Windows 10 15063.540 with Chrome 60.0.3112.90.

.invalid-feedback does correctly appear when the class .is-invalid or :invalid is applied to the input element, but it also appears when .is-valid or :valid is applied to the input. From forms.scss:26:

.form-control,
.custom-select {
   .was-validated &:#{$state},
   &.is-#{$state} {
      border-color: $color;

      &:focus {
        box-shadow: 0 0 0 .2rem rgba($color,.25);
      }

      ~ .invalid-feedback,
      ~ .invalid-tooltip {
        display: block;
      }
  }
}

It appears that the display: block is applied no matter what $state actually is.

@mdo
Copy link
Member

mdo commented Aug 12, 2017

Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via JS Bin and report back with your link, Bootstrap version, and specific browser and OS details.


This is a saved reply.

@charles-toller
Copy link
Author

Bootstrap Version: 4.0.0-beta
OS: Windows 10 15063.540
Browser: Chrome 60.0.3112.90
JS Bin: https://jsbin.com/vizelarani/edit?html,output

@mdo
Copy link
Member

mdo commented Aug 13, 2017

Ahh, I see the problem. Thanks. PR is at #23377.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants