Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.btn-<sm/lg> definitions in _buttons.scss doesn't use $input-btn-line-height-<sm/lg> variable in Bootstrap 4 beta 1 #23407

Closed
dozer75 opened this issue Aug 14, 2017 · 2 comments
Labels

Comments

@dozer75
Copy link

dozer75 commented Aug 14, 2017

The new variables $input-btn-line-height-sm/$input-btn-line-height-lg has been introduced in the latest beta of Bootstrap 4, but this isn't used by the .btn-sm/.btn-lg definition in _buttons.scss, this uses general $line-height-sm/$line-height-lg.

The $input-btn-line-height-sm/$input-btn-line-height-lg should also be defined to default beeing $line-height-sm/$line-height-lg

The .btn definition uses the correct $input-btn-line-height.

@mdo
Copy link
Member

mdo commented Aug 14, 2017

True, those are used everywhere else, but not in the _buttons.scss file.

@mdo
Copy link
Member

mdo commented Oct 2, 2017

First and last paragraphs have been resolved already, but just added a commit in #24199 to fix the middle paragraph's issue.

@mdo mdo closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants