Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: stop cycling if there are other carousels in page and are not visible #23523

Closed
XhmikosR opened this issue Aug 17, 2017 · 1 comment
Closed

Carousel: stop cycling if there are other carousels in page and are not visible #23523

XhmikosR opened this issue Aug 17, 2017 · 1 comment
Labels
js v4

Comments

@XhmikosR
Copy link
Member

Say, one has 3 carousels in the same page with autoplay on. An example would be 3 tabs with a carousel in each tab.

We shouldn't cycle any carousel that is not currently visible.

/CC @Johann-S @mdo @bardiharborow for thoughts
@XhmikosR XhmikosR changed the title Carousel: stop cycling if the there are other carousels in page and are not visible Carousel: stop cycling if there are other carousels in page and are not visible Aug 17, 2017
@Johann-S Johann-S mentioned this issue Aug 17, 2017
Merged
2 tasks
@XhmikosR
Copy link
Member Author

Definitely need to mention it in the release notes.

BTW I haven't been adding the PRs I merge in the release notes. I will from now on, I promise :)

But if we could add everything that's missing that would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XhmikosR