Unnecessary use of jQuery global

[thheller]

It seems to me that bootstrap still has an artificial dependency on the jQuery global that seems unnecessary.

At the top of the file jquery is imported but then the jQuery global is used.

bootstrap/js/src/index.js

Line 1 in a4667be

import $ from 'jquery'

But then the "check" uses the global

bootstrap/js/src/index.js

Lines 21 to 32 in a4667be

	(() => {
	if (typeof jQuery === 'undefined') {
	throw new Error('Bootstrap\'s JavaScript requires jQuery. jQuery must be included before Bootstrap\'s JavaScript.')
	}
	const version = $.fn.jquery.split(' ')[0].split('.')
	const min = 3
	const max = 4
	if (version[0] < min || version[0] >= max) {
	throw new Error('Bootstrap\'s JavaScript requires at least jQuery v3.0.0 but less than v4.0.0')
	}
	})(jQuery)

This pattern is repeated in other files as well, the top imports jquery as $ but then uses jQuery in code. Should it not use $ instead?

I'm asking from a build tool perspective which wouldn't have any issues if the imported object was used instead of the global?

[XhmikosR]

@Johann-S: should we also check for $ in index.js? This should be more flexible.

[Johann-S]

yep agreed with @thheller