Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We are close to 2018 and Bootstrap did not support RTL yet? #24332

Closed
mtawil opened this issue Oct 11, 2017 · 2 comments
Closed

We are close to 2018 and Bootstrap did not support RTL yet? #24332

mtawil opened this issue Oct 11, 2017 · 2 comments
Assignees

Comments

@mtawil
Copy link

mtawil commented Oct 11, 2017

Hello,

Before that, in 2013, I pull a request #10534 and @mdo said that it's okay.
Then I pull a new request #10672 and he rejects that way, funny huh? :D

Anyway, we are now close to 2018, and Bootstrap 4 did not support RTL yet? Seriously?
May I know when you intended to support RTL? in 2030? Or v10?

Thank you.

@Johann-S
Copy link
Member

They are a pull request which target that : #23703

@mdo
Copy link
Member

mdo commented Oct 18, 2017

Beyond us doing it, there have been a handful of options available via third party since v2 even if I recall. I haven't had the time to test ideas and implement this myself, definitely not before shipping a final v4. Most folks that jump to implementing something for us skip any and all conversation about the method of implementation.

Given that, rather than complain, make jokes, and encourage negative criticism from others with your approach in this issue, how about we talk about the multiple methods of implementing RTL? Maybe we talk about who has coded it and how in other similar projects?

The issue and PR you reference are your own from four years ago and coded for v3. I can't recall why I closed it, but I know I never found the time to try out any RTL implementations. One comment on an issue isn't enough of an endorsement for that approach though, and four years later, I imagine it's not the only one.

I'm going to close this one out because it's not the place to have that discussion. I'd happily see a new one opened though with various options.

@mdo mdo closed this as completed Oct 18, 2017
@ffoodd ffoodd mentioned this issue Jun 8, 2020
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants