Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding $font-size-base #24534

Closed
myplaneticket opened this issue Oct 24, 2017 · 2 comments
Closed

Question regarding $font-size-base #24534

myplaneticket opened this issue Oct 24, 2017 · 2 comments
Labels

Comments

@myplaneticket
Copy link

myplaneticket commented Oct 24, 2017

Sorry to post this here, but who better to ask then the creators of BS4 :)

I couldn't find a reliable answer in the docs and was hoping to get some insight here to remove all doubts.

Should the font size for BS4 elements be changed from the root element only?

For example:

html { font-size: 14px }

Is it okay for me to change / override variables (using _custom.scss) in order to alter bootstrap's font size? Or should I not be doing it this way?

For example:

html { font-size: 16px }

// Changing bootstrap variable to 
$font-size-base:             	    0.8125rem; //instead of 1rem
$font-size-lg:                      1.25rem;  
$font-size-sm:   		    0.75rem;  

$h1-font-size: 			    1.5rem;   
$h2-font-size: 			    1.375rem; 
$h3-font-size: 			    1.1875rem;
$h4-font-size: 			    1.0625rem;
$h5-font-size: 		            0.9375rem;
$h6-font-size: 			    0.875rem;

$display1-size:                     5rem !default;
$display2-size:                     4.5rem !default;
$display3-size:                     3.5rem !default;
$display4-size:                     2.5rem !default;
@andresgalante
Copy link
Collaborator

Hey @myorangeca, we've changed font size to be relative to $font-size-base here:
#24060

I'd say change $font-size-base and not the root size

@joneldiablo
Copy link

Hello, I see that $font-size-root not working on 5.1.0 but on 5.0.0 works fine, its an error? o.O

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants