Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG as Breadcrumb Divider #25579

Closed
edodso2 opened this issue Feb 7, 2018 · 2 comments
Closed

SVG as Breadcrumb Divider #25579

edodso2 opened this issue Feb 7, 2018 · 2 comments

Comments

@edodso2
Copy link

edodso2 commented Feb 7, 2018

I am creating a custom theme for Bootstrap and would like to utilize a custom variables file as much as possible. However, I have an issue with the $breadcrumb-divider variable. By default it is set to

$breadcrumb-divider: "/";

But, I want to use an SVG, which seems to be supported by the content property. For example something like this:

$breadcrumb-divider: url(data:image/svg+xml,%3C%3Fxml%20version%...);

The issue is that in breadcrumb.scss quotes are added around $breadcrumb-divider preventing this level of customization:

content: "#{$breadcrumb-divider}";

I know I can easily create my own breadcrumb.scss and override. But, it would certainly be cleaner and more maintainable just to change the variable. Figured it was worth asking about.

Thanks,
Eric

@bkdotcom
Copy link
Contributor

bkdotcom commented Feb 7, 2018

content vs background-image / <img>, <svg>, etc

@edodso2
Copy link
Author

edodso2 commented Feb 7, 2018

I was referring to this method:

content: url("data:image/svg+xml,%3C%3Fxml%20v...);

Not sure about browser support on this or if it is good practice. Even if the framework allowed this for the breadcrumb-divider some fine tuning for the width/height/position would most likely be needed so I guess its not really a big deal to override in a separate file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants