Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap should use float-start, float-end instead of float-left, float-right to stop rtl confusion #26879

Closed
wisamx opened this issue Jul 14, 2018 · 2 comments

Comments

@wisamx
Copy link

wisamx commented Jul 14, 2018

Now when using bootstrap in RTL I used to use this:

[dir=rtl] {
  .float-left {
    float: right;
  }
  .float-right {
    float: left;
  };
}

I think bootstrap should use float-start, float-end instead of float-left, float-right to stop rtl confusion, like this:

  .float-start {
    float: left;
  }
  .float-end {
    float: right;
  };

So I could write:

[dir=rtl] {
  .float-start {
    float: right;
  }
  .float-end {
    float: left;
  };
}
@wolfy1339
Copy link
Contributor

This would be a breaking change, and would need to happen in a major version bump

@mdo
Copy link
Member

mdo commented Jul 14, 2018

@wolfy1339 is correct, and we're aware this would be the preferred approach to directional properties. Thanks!

@mdo mdo closed this as completed Jul 14, 2018
@ffoodd ffoodd mentioned this issue Jun 8, 2020
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants