-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating labels and select positioned with different padding on Firefox #32636
Comments
padding left/right of .5rem fixes the issue for me on Firefox but then it breaks on Chromium. Not sure if it's a browser issue, but it looks like it. |
Material-UI also had this issue. This is also present in the normal Temporary WorkaroundAdd negative @-moz-document url-prefix() {
.form-select {
text-indent: -.13rem;
}
} |
Thanks for your investigation and answers! I would suggest to enhance the bootstrap reboot to resolve this issue? Probably the reboot should unify text-indent of all browsers by a fixed value. What's your opinion? May I provide a PR? |
It seems like Safari has a similar issue with line-height #32672 |
Edit: I'm a dummy and missed the fix was already enabled in the CodePen, sorry! |
Looks like this might be documented as a Firefox bug already: https://bugzilla.mozilla.org/show_bug.cgi?id=1582545. Unsure if we implement the hack, or go with mentioning the bug? Thoughts @twbs/css-review? |
Isn't this related to a fix @MartijnCuppens had for our new file input? I recall talking about a I’d be in favor of implementing the hack, however I'd change |
I don't think so @ffoodd? At least I don't see anything for that in our CSS—might be missing something. I thought the issue was with vertical alignment and sizing, not horizontal. |
The issue is with horizontal alignment, and that Firefox has that extra padding compared to Chromium. IMHO we should add the hack if possible. |
I confirm this is unrelated (found the comment tackling it ATT: #31955 (comment)). However After a few tries, Turning this around, I didn't find a better way. |
|
The PR is assigned to v5.0.2, but this ticket to v5.1.0, please correct this. |
While reading the documentation with the v5 examples, I noticed that the floating labels and select value are off. The following screenshot was taken from the documentation: https://getbootstrap.com/docs/5.0/forms/floating-labels/#selects
I could not reproduce this issue on Safari nor Chrome. My first investigation using the devtools and playing around with different paddings and font-sizes was unsuccessful.
Would you have any hints on resolving this issue? I would be happy to provide a PR.
The text was updated successfully, but these errors were encountered: