Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$accordion-button-color does not set the accordion button color #37092

Closed
3 tasks done
sebastianhomeier opened this issue Sep 6, 2022 · 1 comment · Fixed by #37093
Closed
3 tasks done

$accordion-button-color does not set the accordion button color #37092

sebastianhomeier opened this issue Sep 6, 2022 · 1 comment · Fixed by #37093
Labels

Comments

@sebastianhomeier
Copy link
Contributor

sebastianhomeier commented Sep 6, 2022

Prerequisites

Describe the issue

Current behaviour

Currently, $accordion-color is used to set the accordion button color through --#{$prefix}accordion-btn-color.

--#{$prefix}accordion-btn-color: #{$accordion-color};

However, I expected $accordion-button-color to be used here, which currently only is used as a value for $accordion-icon-color.

I also expected $accordion-color to change the accordion body color, which is currently not the case, but already got fixed in PR #36921.

Expected behaviour

I would expect the $accordion-button-color variable to change the color of the accordion button and $accordion-color to change the color of the accordion body.

Reduced test cases

https://stackblitz.com/edit/bootstrap-5-21hzwn?file=src/styles.scss

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome, Safari, Firefox

What version of Bootstrap are you using?

v5.2.0

@sebastianhomeier
Copy link
Contributor Author

I created a draft PR for this issue: #37093

@mdo mdo added this to v5.2.1 Sep 6, 2022
@mdo mdo moved this to Todo in v5.2.1 Sep 6, 2022
@mdo mdo closed this as completed in #37093 Sep 6, 2022
Repository owner moved this from Todo to Done in v5.2.1 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants