Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: consider adding ngx-bootstrap as a JavaScript framework #40921

Closed
coliff opened this issue Oct 8, 2024 · 1 comment · Fixed by #40932
Closed

Docs: consider adding ngx-bootstrap as a JavaScript framework #40921

coliff opened this issue Oct 8, 2024 · 1 comment · Fixed by #40932

Comments

@coliff
Copy link
Contributor

coliff commented Oct 8, 2024

In the 'Usage with JavaScript frameworks' section: https://getbootstrap.com/docs/5.3/getting-started/javascript/#usage-with-javascript-frameworks it lists ng-bootstrap as a solution for Angular.

I think it might be worth considering adding ngx-bootstrap too. It has 5500 Stars and works great with Bootstrap 5. I'm not affiliated with the project but I have been using it.

@coliff coliff changed the title Docs: consider adding ngx-bootstrap Docs: consider adding ngx-bootstrap as a JavaScript framework Oct 8, 2024
@julien-deramond
Copy link
Member

julien-deramond commented Oct 8, 2024

Personally, I don't mind adding it. I used it in a project for Orange back in the day with Bootstrap 4, and it worked great. Feel free to create a PR for it, @coliff, or I can take care of it if you're short on time. Let's see what the rest of the core team thinks once the PR is up.

Edit: done it in #40932

@github-project-automation github-project-automation bot moved this to To do in v5.3.4 Oct 10, 2024
@julien-deramond julien-deramond moved this from To do to Needs review in v5.3.4 Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Needs review to Done in v5.3.4 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants