Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update affix docs to include mention of potential parent collapse #4671

Closed
koichirose opened this issue Aug 24, 2012 · 2 comments
Closed

Update affix docs to include mention of potential parent collapse #4671

koichirose opened this issue Aug 24, 2012 · 2 comments
Labels
Milestone

Comments

@koichirose
Copy link

I noticed affix uses this css declaration in 'docs.css' and if you don't include it the affixed sidebar will collapse:

/* prevent column from collapsing when affixing */
.span3 {
  min-height: 1px;
}

You should warn the users and save us some time :)

@mdo
Copy link
Member

mdo commented Aug 24, 2012

It's not nonstandard, but yes, it is required and I'll make a mention in the docs for 2.1.1.

@richardp-au
Copy link

Why not simply make this part of the core .spanXX classes? I can't see how this could affect anyone and then they don't have to do it manually when using affix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants