-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The parent option of Collapse does not work without ".accordion-group" css class #4988
Comments
Ran into the same issue today. @soundTricker: Thanks for your fix. Works for me! |
@holgua Thanks :) |
Still having this issue when downloading from the repo |
Would it not be better to add a css class for collapsing non accordion groups? |
parent is for accordions only |
The usage notes specifically say: To add accordion-like group management to a collapsible control, add the data attribute data-parent="#selector". Refer to the demo to see this in action. In other words ... it's NOT for accordions only, it is a method of bringing "accordion-LIKE" group management to other non-accordion elements and, according to the usage notes, should be available without using the full accordion markup. As this issue IS an issue and has not been resolved it should not have been closed! |
Agreed. Why is this closed? At the least the documentation should be updated to note that the accordion group class is required. As it stands it is completely unclear which classes are required and which are optional. This has not been resolved at all. Happy to pull request the above fix if it will help. Patched it in to my branch and everything looks good. |
+1, this is really annoying and lost several hours searching for the answer. Should not be closed, needs a fix. |
Your fix for the bootstrap.js worked for me. |
+1, it should be fixed |
+1. Ran into this issue today. Why is this restricted to https://github.com/twbs/bootstrap/blob/master/js/collapse.js#L51 |
Pull request that solves this problem: #10966 |
The
parent
option of Collapse does not work without.accordion-group
css classHere the jsfiddle.
http://jsfiddle.net/AFPE2/1/
I guess the collapse module should not have dependency with
.accordion-group
css class.but the collapse code has it on here;
Maybe it should be like below.
Now:
Maybe should be...
but sorry, I have not tested its code.
If I have a time, I'll send pull-request.
The text was updated successfully, but these errors were encountered: