Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default panel link color #9095

Closed
leeaston opened this issue Aug 5, 2013 · 5 comments
Closed

Default panel link color #9095

leeaston opened this issue Aug 5, 2013 · 5 comments
Labels

Comments

@leeaston
Copy link

leeaston commented Aug 5, 2013

Not sure about this bit of css. When a list group is inside a basic panel all links in list-group-item become #333.

.panel-title>a {
color: inherit;
}

Should it really be:
.panel-heading>a {
color: inherit;
}

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 5, 2013

But that CSS rule is regarding the panel's title, not the panel's body...

@cvrebert
Copy link
Collaborator

cvrebert commented Aug 5, 2013

jsFiddle example of the problem, if you please.

@leeaston
Copy link
Author

leeaston commented Aug 5, 2013

Ah, my mistake. I'm using panel-title in places it wasn't intended because it squashes margins. I'll have to have a rethink...

@leeaston
Copy link
Author

leeaston commented Aug 5, 2013

Perhaps though, when a default panel is being used the link colour should still be @brand-primary and not inherit #333?

@mdo
Copy link
Member

mdo commented Aug 5, 2013

For now I think we'll leave it. I kind of like the simple aesthetics of it, and it matches the pattern of the other panels.

@mdo mdo closed this as completed Aug 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants