Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer - comment w/ differences #9831

Closed
NinoD opened this issue Aug 19, 2013 · 5 comments
Closed

Customizer - comment w/ differences #9831

NinoD opened this issue Aug 19, 2013 · 5 comments

Comments

@NinoD
Copy link

NinoD commented Aug 19, 2013

Tweeking and upgrading TWBS is neverending story, therefore new v. and patches are imminent.

Would it be nice for customizer to have at the top of customized bootstrap.css comment w/ differences between default and generated customized version?

/!
*
* Customised variables ***

*** Typography ***
@font-family-sans-serif Arial,Helvetica,sans-serif

*** Headings ***
@headings-font-weight 700

*** Components ***
Border radius sizes
@border-radius-base 3px
@border-radius-large 4px
@border-radius-small 2px

etc.
*/

This would make customizing next iteration much easier.
Just a thought.

Thx for all great work (& vids you post)

@mdo
Copy link
Member

mdo commented Aug 19, 2013

Nice thought but we likely won't be going that in the customizer. That's a job for the changeling and blog post.

@mdo mdo closed this as completed Aug 19, 2013
@NinoD
Copy link
Author

NinoD commented Aug 19, 2013

I'm not sure if we understood each other.

Changeling and blog post are for differences you have made between v.2.3.2 and v.3.0.0.

I was thinking of listing a differences between
settings that user made through customizer v.3.0.0.
and
default settings of v.3.0.0.
as comment on top of custom generated bootstrap.css.

That is usefull info for presetting customizer when next versions is released.

Anyway, thx for your answer.

@liuyl
Copy link
Contributor

liuyl commented Aug 19, 2013

I think you can easily do that using any diff tool.

@NinoD
Copy link
Author

NinoD commented Aug 19, 2013

Not easily if compiler creates multiple changes in .css based on one paramater.

i.e. changing
@brand-success
results in changes in
.btn-success, .btn-success.disabled, .progress-bar-success, .label-success

Instead of comparing diffs, I just need to have my (unique) presetting of customizer saved for future updates and patches.

  • I was even thinking of solution of having to upload generated .txt to prefill customiser settings, but its too complicated and too much to ask.

@NinoD
Copy link
Author

NinoD commented Aug 21, 2013

Yeah baby, that's what I was talking 'bout...

http://getbootstrap.com/customize/?id=...
ID saves settings, so tweeking of css can be continued later, w/o inputing all prior changed settings.

It would be nice if that was stated in dosc, rather then mentioned in blog.

Still, although this is perfect for short time usage, I think there are two issues:

  1. for how long IDs will be saved?
  2. I'd preffer having my customizer settings downloaded and saved localy, for safe keeping and reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants