Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_traverse_project.py on Windows #410

Closed
mknorps opened this issue Jan 8, 2024 · 1 comment · Fixed by #412
Closed

Fix test_traverse_project.py on Windows #410

mknorps opened this issue Jan 8, 2024 · 1 comment · Fixed by #412

Comments

@mknorps
Copy link
Collaborator

mknorps commented Jan 8, 2024

Testing of project traversing uses sample project, which are written following Unix patterns.
Checking if the Python virtual environment is valid on Windows (a5fb067) makes those tests obviously fail (see https://github.com/tweag/FawltyDeps/actions/runs/7410859336/job/20164065658).

To fix this we may create "twin" sample projects which follows Windows virtual environment patterns.

@jherland
Copy link
Member

jherland commented Jan 8, 2024

Interesting. This raises a policy question of whether we should detect Unix-style virtualenvs on Windows (or Windows-style virtualenvs on Unix). I guess it comes down to whether we expect our users to run FawltyDeps in this kind of situation?

So either:

  1. Test Unix-style virtualenvs on Unix only, and Windows-style virtualenvs on Windows only.
  2. Test both Unix-style and Windows-style virtualenvs everywhere.

In both cases, we need to add Windows-style virtualenvs to our sample projects. I'm not sure we need to create "twins" of all the sample projects with virtualenvs, but at least one or two to ensure we have sufficient coverage.

@jherland jherland linked a pull request Jan 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants