You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interesting. This raises a policy question of whether we should detect Unix-style virtualenvs on Windows (or Windows-style virtualenvs on Unix). I guess it comes down to whether we expect our users to run FawltyDeps in this kind of situation?
So either:
Test Unix-style virtualenvs on Unix only, and Windows-style virtualenvs on Windows only.
Test both Unix-style and Windows-style virtualenvs everywhere.
In both cases, we need to add Windows-style virtualenvs to our sample projects. I'm not sure we need to create "twins" of all the sample projects with virtualenvs, but at least one or two to ensure we have sufficient coverage.
Testing of project traversing uses sample project, which are written following Unix patterns.
Checking if the Python virtual environment is valid on Windows (a5fb067) makes those tests obviously fail (see https://github.com/tweag/FawltyDeps/actions/runs/7410859336/job/20164065658).
To fix this we may create "twin" sample projects which follows Windows virtual environment patterns.
The text was updated successfully, but these errors were encountered: