From 8a3d3e287161dd9a3c2b541cf0bab890af0c7aa4 Mon Sep 17 00:00:00 2001 From: Philip Patsch Date: Mon, 7 Oct 2019 14:11:59 +0200 Subject: [PATCH] tests/RunTests.hs: fix failure tests Problem description by Andreas Herrmann: > run-tests -m '/failures/' doesn't seem to be working as expected. > The test should attempt to build all targets under > //tests/failures/... that are marked with the manual tag and expect > them to fail. However, if I add the manual tag to a suceeding target > e.g. //tests/failures/transitive-deps:lib-c, then the overall test > still suceeds. Manually tested via description that a succeeding test now actually fails. Fixes https://github.com/tweag/rules_haskell/issues/943 --- tests/RunTests.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/RunTests.hs b/tests/RunTests.hs index 4d4256671..aebddff7e 100644 --- a/tests/RunTests.hs +++ b/tests/RunTests.hs @@ -68,7 +68,7 @@ main = hspec $ do for_ all_failure_tests $ \test -> do it test $ do - assertFailure (bazel ["build", "test"]) + assertFailure (bazel ["build", test]) -- Test that the repl still works if we shadow some Prelude functions it "repl name shadowing" $ do