Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Bazel 6 #43

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Add support for Bazel 6 #43

merged 1 commit into from
Feb 13, 2023

Conversation

z8v
Copy link
Contributor

@z8v z8v commented Feb 9, 2023

Related issue #42

@z8v z8v requested review from aherrmann and avdv as code owners February 9, 2023 13:37
aherrmann
aherrmann reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changes look good.
There are still some CI failures though. Looks like some labels are formatted differently in error messages with Bazel v6.

@z8v z8v force-pushed the bzlmod-6 branch 7 times, most recently from 15afc12 to 679d592 Compare February 9, 2023 22:23
@z8v
Copy link
Contributor Author

z8v commented Feb 9, 2023 •
edited
Loading

Yes, it seems that labels are either prefixed with @// (workspace) or @@// (bzlmod) for the local repo. Maybe there is native function that we can use to remove those prefixes?

@z8v z8v force-pushed the bzlmod-6 branch 4 times, most recently from 74e55e9 to 0d3a379 Compare February 9, 2023 22:44
aherrmann
aherrmann approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good!

@z8v
Copy link
Contributor Author

z8v commented Feb 13, 2023

@aherrmann Should I merge this PR?

@aherrmann
Copy link
Member

@z8v yes, one accepted review is enough to merge. Set the merge-queue label to merge it.

@z8v z8v added the merge-queue merge on green CI label Feb 13, 2023
@mergify mergify bot merged commit ea2c11f into master Feb 13, 2023
@mergify mergify bot removed the merge-queue merge on green CI label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann aherrmann approved these changes

@avdv avdv Awaiting requested review from avdv avdv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z8v @aherrmann