Tweak to #152 so that callables work as regparser type arguments again #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Lars! Thanks for this pull request. I'm a little bit confused as we're currently using callables as types in a few places in our codebase. Perhaps you can add a test which exposes the failure in the current master? |
|
Hello Kevin, I've added some tests to illustrate the issue. The issue only really pops up when using |
|
Looks okay to me. @kevinburke did you want to weigh in again before merging? |
|
LGTM |
skimbrel
added a commit
that referenced
this pull request
Jan 14, 2014
Tweak to #152 so that callables work as regparser type arguments again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.