fix: Fixing ocktokit api calls #211

sr010 · 2022-08-02T19:26:04Z

Fixes release pipeline

Fixes ocktokit api calls in update-release.js script

Screenshot of working API calls made in a test script:

Checklist

I acknowledge that all my contributions will be made under the project's license
I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the Contribution Guidelines and my PR follows them
I have titled the PR appropriately
I have updated my branch with the main branch
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation about the functionality in the appropriate .md file
I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

kridai · 2022-08-03T04:28:33Z

.github/scripts/update-release.js

-    const getReleaseResponse = await github.repos.getReleaseByTag({
+
+    //https://docs.github.com/en/rest/releases/releases#get-a-release-by-tag-name
+    const getReleaseResponse = await octokit.request('GET /repos/{owner}/{repo}/releases/tags/{tag}',{


could we use the helper method mentioned here https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/master/docs/repos/getReleaseByTag.md instead of calling the api directly.

kridai · 2022-08-03T04:33:01Z

.github/scripts/update-release.js

@@ -49,7 +54,8 @@ const updateRelease = async () => {
      prerelease = oldPrerelease;
    }

-    await github.repos.updateRelease({
+    //https://docs.github.com/en/rest/releases/releases#update-a-release
+    await octokit.request('PATCH /repos/{owner}/{repo}/releases/{release_id}', {


similarly see https://github.com/octokit/plugin-rest-endpoint-methods.js/blob/master/docs/repos/updateRelease.md.

* Update update-release.js

## [6.8.0](6.7.0...6.8.0) (2022-08-10) ### Library - Fixes * cleanup keytar ([#209](#209)) ([7a37f0b](7a37f0b)) * Fixing ocktokit api calls ([#211](#211)) ([b025ba2](b025ba2)) * update description ([#207](#207)) ([79c1cc5](79c1cc5))

## [7.0.0](6.8.1...7.0.0) (2022-08-11) ### ⚠ BREAKING CHANGES * unlocking oclif v2 Co-authored-by: sr010 <[email protected]> Co-authored-by: sburman <[email protected]> Co-authored-by: shrutiburman <[email protected]> ### Library - Fixes * Replace oclif-v1 dependencies with oclif-v2 version ([#212](#212)) ([d87c83a](d87c83a)), closes [#207](#207) [#211](#211)

* fix!: update description (twilio#207) * Update twilio-client.test.js * Update base-command.js * fix: Fixing ocktokit api calls (twilio#211) * Update update-release.js * fix: replace oclif v1 dependecies to oclif v2 dependencies * BREAKING CHANGE: unlocking oclif v2 Co-authored-by: sr010 <[email protected]> Co-authored-by: sburman <[email protected]> Co-authored-by: shrutiburman <[email protected]>

## [7.2.0](7.1.0...7.2.0) (2022-09-08) ### ⚠ BREAKING CHANGES * update description (#207) ### Library - Fixes * cleanup keytar ([#209](#209)) ([9f1c2d9](9f1c2d9)) * Fixing ocktokit api calls ([#211](#211)) ([b5150dd](b5150dd)) * update description ([#207](#207)) ([80ae344](80ae344))

Update update-release.js

e45d898

sr010 changed the title ~~Fixing ocktokit api calls~~ fix: Fixing ocktokit api calls Aug 2, 2022

sr010 requested review from kridai, shrutiburman, charan678 and sbansla August 2, 2022 19:40

shrutiburman previously approved these changes Aug 3, 2022

View reviewed changes

kridai reviewed Aug 3, 2022

View reviewed changes

Update update-release.js

0565942

kridai dismissed shrutiburman’s stale review via 0565942 August 3, 2022 06:43

Update update-release.js

80cab32

kridai merged commit b5150dd into twilio:main Aug 3, 2022

shrutiburman pushed a commit that referenced this pull request Aug 10, 2022

fix: Fixing ocktokit api calls (#211)

b025ba2

* Update update-release.js

shrutiburman mentioned this pull request Aug 11, 2022

fix: octokit API call fix #213

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fixing ocktokit api calls #211

fix: Fixing ocktokit api calls #211

sr010 commented Aug 2, 2022 •

edited

Loading

kridai Aug 3, 2022

kridai Aug 3, 2022

fix: Fixing ocktokit api calls #211

fix: Fixing ocktokit api calls #211

Conversation

sr010 commented Aug 2, 2022 • edited Loading

Fixes release pipeline

Checklist

kridai Aug 3, 2022

Choose a reason for hiding this comment

kridai Aug 3, 2022

Choose a reason for hiding this comment

sr010 commented Aug 2, 2022 •

edited

Loading