Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Dockerfile base to be consistent with twilio-cli #226

Merged
merged 2 commits into from
May 31, 2023
Merged

fix: Update Dockerfile base to be consistent with twilio-cli #226

merged 2 commits into from
May 31, 2023

Conversation

kridai
Copy link
Contributor

@kridai kridai commented May 18, 2023

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

shrutiburman
shrutiburman previously approved these changes May 18, 2023
View reviewed changes
AsabuHere
AsabuHere previously approved these changes May 23, 2023
View reviewed changes
@AsabuHere AsabuHere dismissed stale reviews from shrutiburman and themself via 6dba733 May 24, 2023 11:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

AsabuHere
AsabuHere approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@AsabuHere AsabuHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AsabuHere AsabuHere merged commit 73a3c09 into main May 31, 2023
@AsabuHere AsabuHere deleted the dockerfile-changes branch May 31, 2023 08:59
twilio-dx pushed a commit that referenced this pull request Jun 1, 2023
@semantic-release-bot
chore(release): set package.json to 7.10.2 [skip ci]
fff0ed8 
### [7.10.2](7.10.1...7.10.2) (2023-06-01)

### Library - Fixes

* Update Dockerfile base to be consistent with twilio-cli ([#226](#226)) ([73a3c09](73a3c09))
@OrRosenblatt OrRosenblatt mentioned this pull request Jun 8, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsabuHere AsabuHere AsabuHere approved these changes

@shrutiburman shrutiburman shrutiburman approved these changes

@sbansla sbansla Awaiting requested review from sbansla

@charan678 charan678 Awaiting requested review from charan678

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kridai @shrutiburman @AsabuHere