Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessToken identity option should be required #595

Closed
YassienW opened this issue Jul 8, 2020 · 3 comments
Closed

AccessToken identity option should be required #595

YassienW opened this issue Jul 8, 2020 · 3 comments
Labels
status: help wanted requesting help from the community type: bug bug in the library type: community enhancement feature request not on Twilio's roadmap

Comments

@YassienW
Copy link

YassienW commented Jul 8, 2020

Issue Summary

When creating a new AccessToken object, "identity" is an optional parameter of the options object.
https://www.twilio.com/docs/libraries/reference/twilio-node/3.47.0/AccessToken.html

According to the documentation here (and my testing), all access tokens require the following:

  • A Twilio Account SID, which is the public identifier of the Twilio account associated with the Access Token.
  • An API Key SID, which is the public identifier of the key used to sign the token.
  • An Identity grant, which sets the Twilio user identifier for the client holding the token.
  • The API Key Secret associated with the API Key SID is used to sign the Access Token and verify that it is associated with your Twilio account.

I believe identity should be required in the constructor, since that is a breaking change the documentation should at least be updated

Technical details:

  • twilio-node version: 3.47.0
@eshanholtz
Copy link
Contributor

Nice catch. This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@eshanholtz eshanholtz added status: help wanted requesting help from the community type: bug bug in the library type: community enhancement feature request not on Twilio's roadmap labels Jul 10, 2020
@rangelfinal
Copy link

Lost a lot of time for this issue, was getting a generic "Error 20101: Invalid Access Token" until identity was added to access token options

@childish-sambino
Copy link
Contributor

Bumped up the internal backlog (ref: DI-2445).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: bug bug in the library type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

5 participants