Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PySocks dependency #464

Closed
jayvdb opened this issue Apr 19, 2019 · 3 comments · Fixed by #484
Closed

PySocks dependency #464

jayvdb opened this issue Apr 19, 2019 · 3 comments · Fixed by #484
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap

Comments

@jayvdb
Copy link

jayvdb commented Apr 19, 2019

On Python 3, the library depends on PySocks, however I do not see where it is used anymore, and the tests run ok without it, but maybe that is because of lots of mocking.

Apologies if I have missed something.
@eshanholtz eshanholtz added difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing status: help wanted requesting help from the community and removed status: work in progress Twilio or the community is in the process of implementing labels Sep 13, 2019
@childish-sambino childish-sambino added the type: twilio enhancement feature request on Twilio's roadmap label Sep 20, 2019
@Kerl1310
Copy link
Contributor

Kerl1310 commented Oct 6, 2019

Is this just a case of going through and double checking that the package is not being used then removing if so? If it is, then I'm more than happy to pick this up

@childish-sambino
Copy link
Contributor

Yup, that’ll work.

@Kerl1310
Copy link
Contributor

Can't seem to find any references to this package so I've opened a PR to remove

@Kerl1310 Kerl1310 mentioned this issue Oct 15, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/remove socks dependency Kerl1310/twilio-python
4 participants
@jayvdb @Kerl1310 @eshanholtz @childish-sambino