-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLs with IP address as host aren't valid #76
Comments
Somewhat related to #52 (and possibly others) |
In #90 we learned how to extend the PSL, I guess it should be possible to write a PublicSuffix rule that allow IP addresses. :-) |
Or, if we identify the input as an IP address, we could skip the PSL step in that case. |
|
https://github.com/knu/ruby-domain_name
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think they should be valid, they are perfectly valid URLs and I think we want to use URLs like that when we test in our projects... and if the project use twingly-url, it will reject our valid test URLs :-(
They are not valid because of our PublicSuffix demands:
The text was updated successfully, but these errors were encountered: