Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IListeningPort.stopListening is incorrectly typed #10179

Closed
twisted-trac opened this issue Apr 19, 2021 · 3 comments
Closed

IListeningPort.stopListening is incorrectly typed #10179

twisted-trac opened this issue Apr 19, 2021 · 3 comments

Comments

@twisted-trac
Copy link

wiml's avatar @wiml reported
Trac ID trac#10179
Type defect
Created 2021-04-19 02:33:51Z
Branch https://github.com/twisted/twisted/tree/stopListening-returns-deferred

Minor error in ticket:10002

Searchable metadata
trac-id__10179 10179
type__defect defect
reporter__wiml wiml
priority__normal normal
milestone__None None
branch__stopListening_returns_deferred stopListening-returns-deferred
branch_author__ 
status__closed closed
resolution__fixed fixed
component__core core
keywords__mypy mypy
time__1618799631673714 1618799631673714
changetime__1620097287934989 1620097287934989
version__None None
owner__wiml wiml

@twisted-trac
Copy link
Author

wiml's avatar @wiml commented

PR is here #1586

@twisted-trac
Copy link
Author

wsanchez's avatar @wsanchez set owner to @wiml

@twisted-trac
Copy link
Author

wiml's avatar @wiml set status to closed

In changeset f2cd548

#!CommitTicketReference repository="" revision="f2cd548afd26317044544d99bf276bcb861476d7"
Merge pull request #1586 from twisted/stopListening-returns-deferred

Author: wiml
Reviewer: wsanchez
Fixes: ticket:10179

10179: IListeningPort.stopListening() can return a deferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant