Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algebird-util depends on algebird-test #169

Closed
LeifW opened this issue Jun 21, 2013 · 2 comments
Closed

algebird-util depends on algebird-test #169

LeifW opened this issue Jun 21, 2013 · 2 comments
Milestone

Comments

@LeifW
Copy link

LeifW commented Jun 21, 2013

Is this intentional?
As it is now, anything that depends on algebird somewhere pulls in algebird-test, and transitively, its dependencies: specs2 and scalacheck, onto the runtime classpath.

@johnynek
Copy link
Collaborator

Not intentional.

This line is supposed to only create a test dependency:

https://github.com/twitter/algebird/blob/develop/project/Build.scala#L119

a pull req fixing the issue (by checking the pom (make-pom I guess). Indeed now we see:

        <dependency>
            <groupId>com.twitter</groupId>
            <artifactId>algebird-test_2.9.2</artifactId>
            <version>0.1.13</version>
            <scope>compile</scope>
        </dependency>

Which is wrong. We only have a test dep, and that jar does not have the test code.

@sritchie
Copy link
Collaborator

Closed this up in #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants