Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract methods and override issues #80

Open
christydennison opened this issue Jul 11, 2013 · 0 comments
Open

Abstract methods and override issues #80

christydennison opened this issue Jul 11, 2013 · 0 comments
Labels

Comments

@christydennison
Copy link
Contributor

object-oriented-programming/abstract-and-sealed-classes#abstract-methods-and-override

  1. You don't explain override, but you use it as if it were a keyword in the title. There is an exercise called "overriding" but that doesn't imply that we should use the keyword.
  2. You're defining classes within the object Message, but don't really explain why you would do that instead of just defining them outside of the object. It doesn't seem to affect anything when you define the case classes outside of the object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant