Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vinyl file pipe #10

Closed
pruttned opened this issue Nov 6, 2016 · 6 comments
Closed

vinyl file pipe #10

pruttned opened this issue Nov 6, 2016 · 6 comments

Comments

@pruttned
Copy link

pruttned commented Nov 6, 2016

Hi,
pipe method was removed from the vinyl file in v2.0.0
(gulpjs/vinyl#107 ,
gulpjs/vinyl@d14ba4a )
therefore pixelsmith fails at this line
https://github.com/twolfson/pixelsmith/blob/master/lib/engine.js#L40

@twolfson
Copy link
Owner

twolfson commented Nov 6, 2016

I posted a question about alternatives on the linked issue as we will have to add support but also add more tests. I'll check back on this in 1 week as it seems gulp@3 is still on [email protected] which is on [email protected]:

https://github.com/gulpjs/gulp/blob/v3.9.1/package.json#L41

https://github.com/gulpjs/vinyl-fs/blob/v0.3.14/package.json#L21

Reminder: https://twitter.com/twolfsn/status/795367333682290688

@zolotykh
Copy link

@twolfson is there a solution?

@twolfson
Copy link
Owner

The Gulp team never replied on the original issue (gulpjs/vinyl#107) so we're still lacking support. Gulp still seems to be on the [email protected] version though so this hasn't become a priority

When it does become a priority, I feel like we'll probably write a small library (e.g. vinyl-pipe) which copy/pastes the original behavior (gulpjs/vinyl@d14ba4a). Is there any reason y'all are looking for vinyl@2 support?

@twolfson
Copy link
Owner

twolfson commented Jan 3, 2018

It looks like gulp@4 was released over the past few days as I was notified in twolfson/gulp.spritesmith#135

https://github.com/gulpjs/gulp/releases/tag/v4.0.0

This is now a priority but I'm pretty swamped. If someone doesn't beat me to it, then I'll resolve this by the end of the weekend

@twolfson
Copy link
Owner

twolfson commented Jan 6, 2018

Looking into handling this now

@twolfson
Copy link
Owner

twolfson commented Jan 6, 2018

This has been resolved in 2.2.0. I'll be publishing upgrades for spritesmith, gulp.spritesmith, and grunt-spritesmith shortly after that. Additionally, this impacts all spritesmith engines so I'll be adding support to canvassmith, gmsmith, and phantomjssmith after that

@twolfson twolfson closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants